refactor: use common answers file loader#1975
Merged
sisp merged 1 commit intocopier-org:masterfrom Mar 5, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1975 +/- ##
=======================================
Coverage 97.94% 97.94%
=======================================
Files 53 53
Lines 5682 5683 +1
=======================================
+ Hits 5565 5566 +1
Misses 117 117
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pawamoy
reviewed
Feb 19, 2025
pawamoy
approved these changes
Mar 5, 2025
sisp
force-pushed
the
refactor/use-common-answersfile-loader
branch
from
08db834 to
636a0db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've refactored answers file loading to use the common loader function
copier.user_data.load_answersfile_data(). This shall ensure consistent loading behavior for the answers file and external data files.Follow-up of #1970 and #1973.